Skip to content

added Can_wrap_around_more_than_one_day to Clock #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2017
Merged

added Can_wrap_around_more_than_one_day to Clock #265

merged 1 commit into from
Mar 25, 2017

Conversation

jon-peel
Copy link
Contributor

Hi.
I have added a test in the Clock problem.

You can also see the test in my submitted solution

Thank you
P.S. This is the first time I am doing something on GitHub, so I hope I am doing this properly.

@ErikSchierboom
Copy link
Member

Hi,

This looks good to me! Thanks a lot.

Normally, the tests of an exercise should be based on its canonical-data, which also has a similar test. For now, I think it's great to add this test. Eventually, we should be creating a test data generator (see #195), which automatically create tests based on the exercise's canonical data. Unfortunately, the clock exercise is a bit hard to do at the moment, due to the slightly weird test group descriptions, so we'll revisit that later.

Once again, thanks! And for a first effort on GitHub, this is perfect :) 🎉

@ErikSchierboom ErikSchierboom merged commit a581922 into exercism:master Mar 25, 2017
@jon-peel
Copy link
Contributor Author

Thank you very much

ErikSchierboom added a commit to ErikSchierboom/csharp that referenced this pull request Jan 15, 2021
* Add concepts for protein-translation exercise

* Update languages/reference/exercise-concepts/protein-translation.md

Co-Authored-By: Erik Schierboom <[email protected]>

* Update languages/reference/exercise-concepts/protein-translation.md

Co-Authored-By: Erik Schierboom <[email protected]>

* Add alternative approach using a dictionary to store the mapping

Co-authored-by: Erik Schierboom <[email protected]>
ErikSchierboom added a commit to ErikSchierboom/csharp that referenced this pull request Jan 21, 2021
* Add concepts for protein-translation exercise

* Update languages/reference/exercise-concepts/protein-translation.md

Co-Authored-By: Erik Schierboom <[email protected]>

* Update languages/reference/exercise-concepts/protein-translation.md

Co-Authored-By: Erik Schierboom <[email protected]>

* Add alternative approach using a dictionary to store the mapping

Co-authored-by: Erik Schierboom <[email protected]>
ErikSchierboom added a commit to ErikSchierboom/csharp that referenced this pull request Jan 26, 2021
* Add concepts for protein-translation exercise

* Update languages/reference/exercise-concepts/protein-translation.md

Co-Authored-By: Erik Schierboom <[email protected]>

* Update languages/reference/exercise-concepts/protein-translation.md

Co-Authored-By: Erik Schierboom <[email protected]>

* Add alternative approach using a dictionary to store the mapping

Co-authored-by: Erik Schierboom <[email protected]>
ErikSchierboom added a commit to ErikSchierboom/csharp that referenced this pull request Jan 27, 2021
* Add concepts for protein-translation exercise

* Update languages/reference/exercise-concepts/protein-translation.md

Co-Authored-By: Erik Schierboom <[email protected]>

* Update languages/reference/exercise-concepts/protein-translation.md

Co-Authored-By: Erik Schierboom <[email protected]>

* Add alternative approach using a dictionary to store the mapping

Co-authored-by: Erik Schierboom <[email protected]>
ErikSchierboom added a commit to ErikSchierboom/csharp that referenced this pull request Jan 28, 2021
* Add concepts for protein-translation exercise

* Update languages/reference/exercise-concepts/protein-translation.md

Co-Authored-By: Erik Schierboom <[email protected]>

* Update languages/reference/exercise-concepts/protein-translation.md

Co-Authored-By: Erik Schierboom <[email protected]>

* Add alternative approach using a dictionary to store the mapping

Co-authored-by: Erik Schierboom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants