Skip to content

Add OCR Numbers Test Generator #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 3, 2017
Merged

Conversation

GKotfis
Copy link
Contributor

@GKotfis GKotfis commented Oct 2, 2017

This reference #417 issue.

@GKotfis
Copy link
Contributor Author

GKotfis commented Oct 2, 2017

I see that some test cases are not covered. expected value =-1 should be generated as error case.

@ErikSchierboom
Copy link
Member

@GKotfis There are some existing exercises that do something similar. You need to do something like canonicalDataCase.ExceptionThrown = canonicalDataCase.Expected is long ? typeof(ArgumentException) : null;.

@GKotfis
Copy link
Contributor Author

GKotfis commented Oct 2, 2017

Yep after changes still three tests failed because of wrong implementation in Example (I guess Example.cs is used on CI to run tests?)

  1. Input_with_a_number_of_columns_that_is_not_a_multiple_of_three_raises_an_error - return "?" instead of raising error
  2. Input_with_a_number_of_columns_that_is_not_a_multiple_of_three_raises_an_error - return empty string instead of raising error
  3. Numbers_separated_by_empty_lines_are_recognized_lines_are_joined_by_commas_ - throws IndexOutOfRangeException

@ErikSchierboom
Copy link
Member

@GKotfis Ah, you then need to also modify the example implementation. This is due to the canonical data being newer than the one the exercise was originally based on.

You can verify the example implementation by doing the CI build locally, but only for one specific exercise: .\build.ps1 --exercise=ocr-numbers (or ./build.sh --exercise=ocr-numbers on Linux/macOS). This will execute the same steps as the CI server, but for only the specified exercise.

Grzegorz Kotfis added 2 commits October 2, 2017 22:56
- error cases: invalid lines/columns numbers
- multiline input joined by commas
@ErikSchierboom
Copy link
Member

Great work @GKotfis ! Merged. Thanks! 🎉

@ErikSchierboom ErikSchierboom merged commit db97b71 into exercism:master Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants