-
-
Notifications
You must be signed in to change notification settings - Fork 365
Add OCR Numbers Test Generator #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Rename method to more meaningful
I see that some test cases are not covered. expected value =-1 should be generated as error case. |
@GKotfis There are some existing exercises that do something similar. You need to do something like |
Yep after changes still three tests failed because of wrong implementation in Example (I guess Example.cs is used on CI to run tests?)
|
@GKotfis Ah, you then need to also modify the example implementation. This is due to the canonical data being newer than the one the exercise was originally based on. You can verify the example implementation by doing the CI build locally, but only for one specific exercise: |
- error cases: invalid lines/columns numbers - multiline input joined by commas
Great work @GKotfis ! Merged. Thanks! 🎉 |
This reference #417 issue.