Add Saddle Points test generator #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add SaddlePoint test generator - add multidimensional value formater
ErikSchierboom
requested changes
Oct 5, 2017
generators/Exercises/SaddlePoints.cs
Outdated
|
|
||
| canonicalDataCase.Properties["input"] = (canonicalDataCase.Properties["input"] as JArray).ToObject<int[,]>(); | ||
|
|
||
| var array = (canonicalDataCase.Expected as Array); |
There was a problem hiding this comment.
You can lose the parentheses here
| { | ||
| var input = new[,] | ||
| { | ||
| { 9, 8, 7 }, |
There was a problem hiding this comment.
The indentation is slight off (also in the other cases), I would expect the following:
var input = new[,]
{
{ 9, 8, 7 },
};- cleanup test generator
ErikSchierboom
approved these changes
Oct 5, 2017
|
I'll do refactoring in separate PR |
|
Merged. Thanks again! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reference #421 issue.
What do you think about those changes - extension of ValueFormatter? :) This switch(val) in Format method gets bigger and bigger so maybe some refactoring needs to be done here (at least split to methods).