add connect generator and modify class to accept array input #464
Conversation
exercises/connect/ConnectTest.cs
Outdated
| { | ||
| return string.Join("\n", board.Select(x => x.Replace(" ", ""))); | ||
| var board = new[] { ".....", ".....", ".....", ".....", "....." }; |
There was a problem hiding this comment.
For the Connect case, it is quite important that the input strings are aligned nicely under each other, to allow users to see the pattern that needs to be connected. By default, the generator framework does not support this. but perhaps you can "borrow" from this generator?
generators/Exercises/Connect.cs
Outdated
| canonicalDataCase.SetConstructorInputParameters("board"); | ||
|
|
||
| //remove whitespace | ||
| var trimBoard = new List<string>(); |
There was a problem hiding this comment.
Why trim the white space? The original implementation also doesn't trim it and this makes it look better IMHO. Could you remove the trimming?
There was a problem hiding this comment.
If I don't trim it the tests where failing because I think it's looping through every character and taking the spaces as an empty space. I could be wrong, I'll look into it.
|
@ErikSchierboom I pushed up some changes. I aligned the arrays better, but I couldn't figure out how to get rid of the empty line at the end of the array. Besides that, hopefully I addressed your comments. |
There was a problem hiding this comment.
It's much better already! I have a small nit about the indentation. As for how you can get rid of the newline, you could also use some plain old LINQ to format the lines, which would make it a lot easier to control such things. If you don't agree or it doesn't work out, feel free to ignore this and only fix the indentation as requested in the comment.
Thanks a lot for the hard work!
exercises/connect/ConnectTest.cs
Outdated
| { | ||
| return string.Join("\n", board.Select(x => x.Replace(" ", ""))); | ||
| var board = new [] | ||
| { |
There was a problem hiding this comment.
Could you perhaps use less indentation? Something like this looks better IMHO:
var board = new []
{
". . . . .",
" . . . . .",
" . . . . .",
" . . . . .",
" . . . . ."
};
|
Merged. Thanks a lot. 🎉 |
Adds the Connect generator. Minor modifications to the class to accept an array as input.
Resolves #404