-
-
Notifications
You must be signed in to change notification settings - Fork 365
Single exercise option #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single exercise option #491
Conversation
This makes is consistent with the build script
generators/Exercises/Diamond.cs
Outdated
namespace Generators.Exercises | ||
{ | ||
public class Diamond : CustomExercise | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably worth adding a comment here on why we decided not to follow the canonical data for this exercise (here's it's because we wanted to do property based testing). That way if something changes in the future and we want to revisit that decision we have the info here without digging through the issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I've updated the PR.
|
||
Log.Information("{Exercise}: tests generated", exercise.Name); | ||
break; | ||
case UnimplementedExercise _: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you remove the underscores here since they're not used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, unfortunately not. I tried that at first, but then it isn't a valid pattern match anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm ok I thought you could, thanks for checking!
Awesome work @ErikSchierboom... you took what I had in mind even a step further that's great! I added a couple of minor comments, but feel free to merge yourself even if you make changes for my comments as they're minor. |
Thanks @ErikSchierboom! |
This PR adds functionality to fix #434 (show status of all exercises). When running the test generator, all the track's exercises are checked to see what to do. There are four options:
CustomExercise
. In this case, we assume that the tests are crafter manually and don't run a generator.I've also added an option to filter on the above mentioned statuses, which you can do by providing a command-line option. For example,
dotnet run -s Unimplemented
would show only those exercises with canonical data but without a generator.