Add 5 new exercises #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| using System.Linq; | ||
|
|
||
| public class BinarySearchTree<T> | ||
| where T : IComparable |
Contributor
There was a problem hiding this comment.
The exercise only talks about using numbers so there's no point in making this generic. I would keep it simple and just make this non-generic and use ints.
Member
|
@ErikSchierboom @bressain I'm going to leave this discussion to the two of you since I don't know C#. If you are happy with any individual exercises, it might be worth sticking them in separate PRs or cherry-picking them while you keep working on and discussing the others. Or not :) |
Contributor
|
Looks good, thanks for doing these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds four new exercises:
These are all open exercises as listed in #2.
I hope someone would be willing to give some feedback on the design. In particular, I struggled with the design of the palindrome products.