-
-
Notifications
You must be signed in to change notification settings - Fork 365
Updates the README files for various exercises #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates the README files for various exercises #696
Conversation
Ran the `update-docs.sh` script to update the README files and apply any patches that were necessary.
@ErikSchierboom I changed my mind, a batch of README updates is just easier. Having individual PR's for each would just be too much overhead. |
exercises/accumulate/README.md
Outdated
@@ -33,10 +33,6 @@ This exercise requires you to write an extension method. For more information, s | |||
|
|||
To run the tests, run the command `dotnet test` from within the exercise directory. | |||
|
|||
### Laziness test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is odd. I would have expected this patch to be included. Would you mind looking into why this patch did not get included?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the patch failed to apply. Updating the docs with the update-docs.sh
script removes the Laziness test section entirely and that patch file only updates the wording of that section. I'll see what I can do to update that patch file for the change to be applied correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
@ErikSchierboom The patch file should be fixed now. |
It looks like there have been updates to |
I can just squash and merge from the GitHub GUI, which I just did. Thanks for doing this! |
Ran the
update-docs.sh
script to update the README files and apply any patches that were necessary.