Skip to content

Updates the README files for various exercises #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2018

Conversation

Zureka
Copy link
Contributor

@Zureka Zureka commented Oct 10, 2018

Ran the update-docs.sh script to update the README files and apply any patches that were necessary.

Ran the `update-docs.sh` script to update the README files and apply any
patches that were necessary.
@Zureka
Copy link
Contributor Author

Zureka commented Oct 10, 2018

@ErikSchierboom I changed my mind, a batch of README updates is just easier. Having individual PR's for each would just be too much overhead.

@@ -33,10 +33,6 @@ This exercise requires you to write an extension method. For more information, s

To run the tests, run the command `dotnet test` from within the exercise directory.

### Laziness test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is odd. I would have expected this patch to be included. Would you mind looking into why this patch did not get included?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the patch failed to apply. Updating the docs with the update-docs.sh script removes the Laziness test section entirely and that patch file only updates the wording of that section. I'll see what I can do to update that patch file for the change to be applied correctly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Zureka
Copy link
Contributor Author

Zureka commented Oct 12, 2018

@ErikSchierboom The patch file should be fixed now.

@Zureka
Copy link
Contributor Author

Zureka commented Oct 12, 2018

It looks like there have been updates to master since this branch was created. Do you have a preferred rebase strategy you would like me to follow or would just merging this branch into master as is be sufficient?

@ErikSchierboom ErikSchierboom merged commit 63ed0c1 into exercism:master Oct 12, 2018
@ErikSchierboom
Copy link
Member

I can just squash and merge from the GitHub GUI, which I just did. Thanks for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants