-
-
Notifications
You must be signed in to change notification settings - Fork 34
Pascals-triangle: add exercise #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This looks good so far. How did you create the README? Take a look at exercism/problem-specifications#1341. I will be merging that PR maybe this evening (my time). If you review what I plan to merge you can get a head start and make those changes to your code now. I'll get the config.json updated later, hopefully by this evening. |
i just tested out your code. 👍 Thanks for working on this! |
Readme is created by configlet. I didn't modify it at all. |
I am surprised that it could build the readme without the config.json file being update first. Teh configlet must just be matching folder names between the Delphi and Problem-Specifications repos. config.json updated btw. |
I had to make a little workaround to create readme. I put problem-specifications in exercism directory. |
it is better to keep all exercism repos with a single folder. I have a folder called exercism and within it I have Delphi, CSharp, and problem-specifications etc. If you folder names are the same as the original repo name configlet will find what it needs. If you have changed the folder names (like I have) then you need to use the when I am in my exercism-delphi folder I must:
in order to generate all the READMEs for Delphi. Until today I assumed that configlet was parsing config.json to determine which exercises to make READMEs for. You have shown me that it is simply traversing the exercises folder in each of the two repos and generating READMEs for folders that match. |
I am going to go ahead and merge this. |
You will want to delete the branch and do a FF pull from exercism master to local master. Then push to origin master. |
Ok. I ll work on OCR numbers now |
Config.json is missing