Skip to content

Pascals-triangle: add exercise #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2018

Conversation

filiptoskovic
Copy link
Contributor

Config.json is missing

@rpottsoh rpottsoh changed the title Pascals triangle Pascals-triangle: add exercise Sep 25, 2018
@rpottsoh
Copy link
Member

This looks good so far. How did you create the README?

Take a look at exercism/problem-specifications#1341. I will be merging that PR maybe this evening (my time). If you review what I plan to merge you can get a head start and make those changes to your code now.

I'll get the config.json updated later, hopefully by this evening.

@rpottsoh
Copy link
Member

i just tested out your code. 👍 Thanks for working on this!

@filiptoskovic
Copy link
Contributor Author

Readme is created by configlet. I didn't modify it at all.

@rpottsoh
Copy link
Member

I am surprised that it could build the readme without the config.json file being update first. Teh configlet must just be matching folder names between the Delphi and Problem-Specifications repos.

config.json updated btw.

@filiptoskovic
Copy link
Contributor Author

I had to make a little workaround to create readme. I put problem-specifications in exercism directory.

@rpottsoh
Copy link
Member

it is better to keep all exercism repos with a single folder. I have a folder called exercism and within it I have Delphi, CSharp, and problem-specifications etc. If you folder names are the same as the original repo name configlet will find what it needs. If you have changed the folder names (like I have) then you need to use the -p command line switch.

when I am in my exercism-delphi folder I must:

configlet generate . -p ..\exercism-problem-specifications

in order to generate all the READMEs for Delphi.

Until today I assumed that configlet was parsing config.json to determine which exercises to make READMEs for. You have shown me that it is simply traversing the exercises folder in each of the two repos and generating READMEs for folders that match.

@rpottsoh
Copy link
Member

I am going to go ahead and merge this.

@rpottsoh rpottsoh merged commit e127663 into exercism:master Sep 25, 2018
@rpottsoh
Copy link
Member

You will want to delete the branch and do a FF pull from exercism master to local master. Then push to origin master.

@filiptoskovic
Copy link
Contributor Author

Ok. I ll work on OCR numbers now

@filiptoskovic filiptoskovic deleted the pascals-triangle branch September 25, 2018 20:01
@filiptoskovic filiptoskovic restored the pascals-triangle branch September 25, 2018 20:01
@filiptoskovic filiptoskovic deleted the pascals-triangle branch September 25, 2018 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants