Skip to content

RNA-Transcription: Add invalid input #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

amoradell
Copy link
Contributor

Test with invalid input raises exception

Test with invalid input raises exception
@rpottsoh rpottsoh changed the title Add invalid input RNA-Transcription: Add invalid input Oct 8, 2018
@rpottsoh
Copy link
Member

rpottsoh commented Oct 8, 2018

@amoradell I don't think I want to make these changes. I would like to keep the exercise in sync with the exercise as it is described in problem-specifications. Furthermore efforts were made to remove tests on bad input as they have been deemed to be unrelated to solving the problem at hand. PR exercism/problem-specifications#1027 removed tests for bad input.

@rpottsoh rpottsoh closed this Oct 8, 2018
@amoradell
Copy link
Contributor Author

Ok, it's more consistent with problem specifications. It's just that other tracks test invalid inputs and expect error correctly handled. I changed my comment on Zorica exercise.

@rpottsoh
Copy link
Member

rpottsoh commented Oct 8, 2018

The current trend is to not spend energy testing for bad input. In a production environment typically upstream code would take care of making sure the input was proper before handing the data off to be processed. Unless the exercises focus is on detecting bad input the main goal of the exercise shouldn't be encumbered with dealing with bad input. Many tracks are slow to update their implementations and others just choose to not follow the canonical data.

@amoradell
Copy link
Contributor Author

It's better to find edge cases, I think.

@rpottsoh
Copy link
Member

If the input is valid then it can be useful to find edge cases where the algorithm doesn't properly process the valid input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants