Skip to content

Fix old implicit reference to v3 repo #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Fix old implicit reference to v3 repo #74

merged 2 commits into from
Mar 2, 2021

Conversation

iHiD
Copy link
Member

@iHiD iHiD commented Mar 2, 2021

No description provided.

@loziniak
Copy link
Member

loziniak commented Mar 2, 2021

It's the same for Creating an Representer and Creating a Test Runner

@iHiD
Copy link
Member Author

iHiD commented Mar 2, 2021

Thanks. Want to PR those? :)

@loziniak
Copy link
Member

loziniak commented Mar 2, 2021

No problem.

loziniak added a commit to loziniak/docs-1 that referenced this pull request Mar 2, 2021
@loziniak loziniak mentioned this pull request Mar 2, 2021
loziniak added a commit to loziniak/docs-1 that referenced this pull request Mar 2, 2021
@loziniak loziniak mentioned this pull request Mar 2, 2021
@@ -6,6 +6,8 @@ These are the steps to get going:

1. Check [our repository list for an existing `...-analyzer`](https://github.com/exercism?q=-analyzer) to ensure that one doesn't already exist.
2. Scan the [contents of this directory](./) to ensure you are comfortable with the idea of creating an Analyzer.
3. Open an issue at [exercism/exercism](https://github.com/exercism/exercism/issues/new) introducing yourself and telling us which language you'd like to create a Analayzer for.
3. Open an issue at [exercism/exercism][exercism-repo] introducing yourself and telling us which language you'd like to create a Analayzer for.
Copy link
Member

@ErikSchierboom ErikSchierboom Mar 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not do:

Suggested change
3. Open an issue at [exercism/exercism][exercism-repo] introducing yourself and telling us which language you'd like to create a Analayzer for.
3. [Open an issue at exercism/exercism](https://github.com/exercism/exercism/issues/new) introducing yourself and telling us which language you'd like to create a Analyzer for.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two reasons:

  1. Your other PR said we shouldn't use internal links, so I moved it to the end of the file 😛
  2. I figured we might have more info at the apex of the exercism/exercism directory, and possibly have issue templates and things so that it might be better to send someone to the apex. But I can be persuaded either way on this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. True :)
  2. It would be really nice to have an issue template. That is something we should do at some point. Feel free to merge as is. I'll approve.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ta :)

@iHiD iHiD merged commit 53e3e9d into main Mar 2, 2021
@iHiD iHiD deleted the iHiD-patch-3 branch March 2, 2021 16:00
iHiD pushed a commit that referenced this pull request Mar 18, 2021
iHiD pushed a commit that referenced this pull request Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants