Update tests and example implementation for bowling
#270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devonestes
force-pushed
the
update-bowling-tests
branch
from
092b1d4 to
a589920
Compare
There were some changes to the `cannonical_data.json` file for the `bowling` exercise, so we needed to update our implementation to be consistent with the rest of the exercises in Exercism. This will be a breaking change for existing implementations, and there are just flat out new requirements in the new `cannonical_data`, so I'm not 100% sure how we want to handle that. I know it's still something we're discussing, and I'd love to hear the input from other folks on the importance of keeping up to date with the Exercism standard `cannonical_data` vs. not making breaking changes. Closes exercism#269
|
@devonestes should we also update the test descriptions to match? |
|
@parkerl I updated all the description strings to match what was in the Or did you mean something else and I just misunderstood you? |
|
Great! That was what I meant. Thanks 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some changes to the
cannonical_data.jsonfile for thebowlingexercise, so we needed to update our implementation to be consistent with the
rest of the exercises in Exercism.
This will be a breaking change for existing implementations, and there are just
flat out new requirements in the new
cannonical_data, so I'm not 100% surehow we want to handle that. I know it's still something we're discussing, and
I'd love to hear the input from other folks on the importance of keeping up to
date with the Exercism standard
cannonical_datavs. not making breakingchanges.
Closes #269