Skip to content

Make run-length-encoding exercise expected values consistent with README #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 8, 2017
Merged

Make run-length-encoding exercise expected values consistent with README #293

merged 4 commits into from
Feb 8, 2017

Conversation

daveyarwood
Copy link
Contributor

Fixes #292.

@devonestes
Copy link
Contributor

@daveyarwood This is great! I just noticed, though, that there is a cannonical_data.json file for this exercise, so while we're making this breaking change, we might as well try and make this implementation line up with that set of tests. Here's the link to that file: https://github.com/exercism/x-common/blob/master/exercises/run-length-encoding/canonical-data.json

In general these tests are enough to get folks to the correct implementation so there aren't duplicate tests that will all pass at once. It would be great if you wanted to make the tests for this exercise line up with that file!

@daveyarwood
Copy link
Contributor Author

@devonestes Done!

There is one test case that doesn't work because the input string doesn't contain exclusively uppercase letters. I've filed exercism/problem-specifications#537 to address that in canonical-data.json.

@devonestes
Copy link
Contributor

@daveyarwood Thanks for the quick work on that! I checked out that issue, and from the conversation there it looks like we'll need to implement the ability to keep track of spaces, as well as uppercase and lowercase letters. However, I have a feeling that once that bit is ready then this can be merged!

@daveyarwood
Copy link
Contributor Author

daveyarwood commented Feb 8, 2017

@devonestes I've adjusted the example solution so that it works with lowercase letters and whitespace, including the last test case in canonical-data.json.

I also submitted a PR to x-common to adjust the description there (EDIT: it's been merged now), so things should be consistent once both PRs are merged.

@devonestes
Copy link
Contributor

@daveyarwood Awesome work - thanks! 👍

@devonestes devonestes merged commit 5cffdef into exercism:master Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants