Skip to content

Simple cipher remove test: do not check what happens with invalid input #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

jiegillet
Copy link
Contributor

Fix #851.

I'm not pushing this particular fix, dropping "only lowercase a-z are translated, rest are passed through" is another valid resolution, but I made the change on my work laptop, and I probably won't have it later. Feel free to pick your preferred fix @angelikatyborska :)

PS: sorry for the messy commits, I have to rush a bit.

@github-actions
Copy link
Contributor

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?
  • Practice exercise changed

    • 🌲 Do prerequisites, practices, and difficulty in config.json need to be updated?
    • 🧑‍🏫 Are the changes in accordance with the community-wide problem specifiations?
  • Practice exercise tests changed

    • ⚪️ Are all tests except the first one skipped?
    • 📜 Does <exercise>/.meta/tests.toml need updating?

Automated comment created by PR Commenter 🤖.

@jiegillet jiegillet closed this Aug 26, 2021
@jiegillet jiegillet deleted the jie-simple-cipher branch August 26, 2021 05:56
@jiegillet jiegillet restored the jie-simple-cipher branch August 26, 2021 09:34
@jiegillet
Copy link
Contributor Author

jiegillet commented Aug 26, 2021

Did I close this? I didn't mean to... Oh, I think I deleted the branch by mistake, maybe that's what happened...

@jiegillet jiegillet reopened this Aug 26, 2021
@angelikatyborska angelikatyborska changed the title Add test: passed through letters consume key letters Simple cipher remove test: do not check what happens with invalid input Aug 27, 2021
@angelikatyborska angelikatyborska merged commit a510215 into exercism:main Aug 27, 2021
@jiegillet jiegillet deleted the jie-simple-cipher branch September 18, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simple cipher ignore spaces etc
2 participants