Exercise bob #40
Merged
Exercise bob #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exercise bob added with cmake and ctest
Exercise hello world added with cmake and ctest
kotp
suggested changes
Aug 16, 2019
There was a problem hiding this comment.
Combining concerns of two different exercises is something we will want to avoid in a merge request. That said, leave this combined, as there is no need to worry about it at this moment.
The reason that I would have to separate the exercises out is because the need for changes to Bob shouldn't stop Hello World from coming in... and vise versa.
|
#41 is the Hello World exercise, so we can concentrate on "Bob" here. |
Merged changes from master and integrated comments from pull request like renaming heyBob-->bob and adding comments for students in begining of bob_test.f90
Exercise bob added with cmake and ctest
…rtran into exercise_hello_world_and_bob
SaschaMann
approved these changes
Oct 6, 2019
|
@pclausen this looks good, if you would want to do an interactive rebase (or not interactive) and fix up the history of the commits to tell this wonderful story, feel free to that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exercise hello world and bob added with cmake and ctest. FUnit files not removed yet.