triangle: Ensure no pair of triangle types are equal #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in #207, the triangle tests can be solved by a trivial empty implementation that simply sets all four triangle types equal to one another. We should prevent false positives, and we can do so by checking that Equ != Iso, etc. I verified that 1) the trivial solution fails the new test, and 2) the example solution passes the test. Fixes #207
|
This looks good to me. |
petertseng
added a commit
that referenced
this pull request
Dec 7, 2015
triangle: Ensure no pair of triangle types are equal
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #207, the triangle tests can be solved by a trivial empty
implementation that simply sets all four triangle types equal to one
another. We should prevent false positives, and we can do so by checking
that Equ != Iso, etc.
I verified that 1) the trivial solution fails the new test, and 2) the
example solution passes the test.
Fixes #207