Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
@KasimKaizer Would you like to resync this from the problem spec and get it merged? |
|
@IsaacG Yes please, I would appreciate that. |
|
@KasimKaizer Go for it. I was just added to the maintainer list and I'm still sorting out getting merge permissions but I'd be happy to merge in new exercises once they're updated to match the latest version from the problem specs! |
| var tmpl = `package affinecipher | ||
|
|
||
| {{.Header}} |
There was a problem hiding this comment.
| var tmpl = `package affinecipher | |
| {{.Header}} | |
| var tmpl = `{{.Header}} |
There was a problem hiding this comment.
Should I really do this?
Because in the README of the Go track, they specifically ask for
"var tmpl = `package
{{.Header}}"
There was a problem hiding this comment.
the teast cases file needs to package name
There was a problem hiding this comment.
The package name is added by the {{.Header}}. However, you may need to rebase your PR to pick up the generator changes.
|
@KasimKaizer Ping? |
IsaacG
added
x:action/create
|
@KasimKaizer FYI If I don't hear back from you in the next few days, I may close this out and implement it myself. |
|
Sorry for the delay @IsaacG I am currently in the Middle East, and with everything going on here, I have a lot on my plate at the moment. I will try to get this implemented as soon as possible (max by next week). |
|
Sounds good. If it takes longer, that's fine, so long as I have some idea that it's not abandoned 🙂 |
Update go version Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
remove 'short mode' Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Use the new 'range' method Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
update tmpl generation Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
correct module name Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
4 participants
No description provided.