-
-
Notifications
You must be signed in to change notification settings - Fork 674
travis: update go versions #887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the contrib @dvrkps! The extra files included in the commit are a side-effect we are seeing from having the master and nextercism branches. They should not be in this commit, so see how we figure it out in #862. Also while the nextercism travis file is outdated, the master one is actually ahead of this commit: go:
- 1.8.3
- 1.9
- tip I wonder if we should be merging/rebasing |
@tleen you didn't ask me but I'd say definitely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me but it's better to base PR into master, IMHO.
- 1.7.5 | ||
- 1.8 | ||
- 1.8.x | ||
- 1.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
# but anyway, it could happen and it wouldn't be our problem. | ||
matrix: | ||
include: | ||
# Keep this in sync with the latest version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe comment can be removed. 2.x isn't close.
😳 Apologies @ferhatelmas ! I didn't want to spam people with mentions, I'll hit the whole group next time. |
Can I add this in master branch also ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed this to be merged into the master branch.
This is good to merge with the suggested line deletion from @ferhatelmas
Thanks @dvrkps! I didn't know you could do this with Travis, learnt something 👍
Yeah, for sure.
|
I haven't. I thought I had, but I had just pushed to my own repo If one of us rebases
...then they would have to force push up to this repo. This can have any number of negative consequences, including attaching that person to many of the commits Honestly, I'm not sure of the best way to keep the I'm going to merge this in to Thanks again @dvrkps! 🎉 |
No description provided.