Skip to content

Enable merge commits #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
petertseng opened this issue Aug 15, 2022 · 5 comments
Closed

Enable merge commits #1087

petertseng opened this issue Aug 15, 2022 · 5 comments

Comments

@petertseng
Copy link
Member

@ErikSchierboom and/or @iHiD, it would be preferable (but neither required nor urgent) if you would do me the favour of enabling merge commits for this repo again.

I am not sure when the change was made. It is confirmed that I was able to make a merge commit on 2022-03-06, which is the date of e5f2970, the most recent merge commit made. I know I could not make a merge commit on 2022-07-22, because I reported my inability in #1025. The option says "not enabled for this branch", which means the setting that is forbidding it is a branch-specific setting, not a repo-specific setting.

My records show that in #911 and exercism/rust#979, it was necessary to uncheck the "Require linear history" box.

If this is some new organisation rule that merge commits will not be allowed, just let me know and I'll adjust my workflow accordingly. I've been making do for the time being and I can continue to do so, but if the intent is to make it available to the maintainers that want it, I want it.

@ErikSchierboom
Copy link
Member

@petertseng We've enabled merge commits for this repo. Our global policy is to steer people towards using squash merges, but if individual repos want to have merge commits enabled, that's fine.

@iHiD
Copy link
Member

iHiD commented Aug 16, 2022

(I've just fixed the branch protection on main to allow merge commits too - @ErikSchierboom you might want to update your script to honour the existing setting to require linear history for now?)

@petertseng
Copy link
Member Author

I'll check when processing the next PRs and report back

@ErikSchierboom
Copy link
Member

@iHiD No need. We're already respecting the existing linear history setting: https://github.com/exercism/website/pull/2782/files#diff-a8aefcd589358c15bd1202a716871bd7428232fc88a61506ea6694d26c7a2766R27

@petertseng
Copy link
Member Author

was finally able to confirm that merge commits are enabled again, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants