sgf-parsing: Explain all current test cases + Add individual tests of escaping/whitespace behaviour #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertseng
force-pushed
the
sgf
branch
2 times, most recently
from
ea9a596 to
a47b673
Compare
|
Could merge commits be enabled for this repository? In the meantime I will rebase and merge this one. |
It may otherwise be too cryptic why some of these things are errors exercism#1025
previous case "escaped property value" crams too much into one test case. Split it up into multiple ones. The reimplemented case is mostly as it was when the exercise was originally implemented in exercism/exercism@7a5075b Note that the original case also got it wrong in that newlines should remain newlines; this is corrected in the new case. exercism/problem-specifications#1889 exercism#1025
petertseng
added a commit
that referenced
this pull request
Jul 22, 2022
It may otherwise be too cryptic why some of these things are errors #1025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Individual commit messages speak.