-
-
Notifications
You must be signed in to change notification settings - Fork 195
rna-transcription: Change return type to Maybe #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The exercise, for reference. http://exercism.io/exercises/haskell/rna-transcription/readme |
This sounds like a good move to me. That would align with other changes we've been making, per #115 |
👍 for that! We could even supply a stub |
samjonester
added a commit
to samjonester/xhaskell
that referenced
this issue
Jun 30, 2016
- Error case is now defined, eliminating the desire to throw an `error` for invalid input. - The test and example solution are more idiomatic to Haskell, using a `Maybe`. Closes exercism#166
samjonester
added a commit
to samjonester/xhaskell
that referenced
this issue
Jun 30, 2016
- Error case is now defined, eliminating the desire to throw an `error` for invalid input. - The test and example solution are more idiomatic to Haskell, using a `Maybe`. Closes exercism#166
samjonester
added a commit
to samjonester/xhaskell
that referenced
this issue
Jun 30, 2016
- Error case is now defined, eliminating the desire to throw an `error` for invalid input. - The test and example solution are more idiomatic to Haskell, using a `Maybe`. Closes exercism#166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This exercise doesn't define a test case for "non dna" characters, so many people are throwing errors for invalid input unnecessarily. It seems like that solution has gone viral, and since it's early in the haskell track could influence people to throw errors instead of using the safer type of
Maybe
. Thoughts on making this change?The text was updated successfully, but these errors were encountered: