Skip to content

Gigasecond Improvement #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lpalma opened this issue Mar 11, 2017 · 2 comments
Closed

Gigasecond Improvement #503

lpalma opened this issue Mar 11, 2017 · 2 comments

Comments

@lpalma
Copy link
Contributor

lpalma commented Mar 11, 2017

While working on Gigasecond exercise, as part of #473, I noticed two things:

  1. The exercise is not documented in the exercises page;
  2. The function name fromDay may be confusing for beginners since it doesn't take a day, but rather a UTCTime. What about simply from or fromUtcTime ?

Perhaps this repository is not responsible for 1 and it should be raised in exercism.io instead?

@petertseng
Copy link
Member

petertseng commented Mar 11, 2017

The exercise is not documented in the exercises page;

Because it is deprecated in this repo, and deprecated exercises intentionally do not show up in the list.

Do we want to cover deprecated exercises too as part of #473?

The function name fromDay may be confusing for beginners since it doesn't take a day, but rather a UTCTime. What about simply from or fromUtcTime ?

Sure, either seems reasonable. I guess it was called fromDay because despite taking in a UTCTime, the time always had the hour/minute/second set to zero, but that is caused by the tests, not the function - the function would reasonably be able to accept any UTCTime, not just those at 00:00:00

@lpalma
Copy link
Contributor Author

lpalma commented Mar 12, 2017

I think this can be closed now following #473 (comment)

@rbasso rbasso closed this as completed Mar 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants