-
-
Notifications
You must be signed in to change notification settings - Fork 195
New .gitignore based on GitHub's default. #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
At the moment, it's only practical to build the examples and tests in To avoid accidental inclusion of build directories and local project files in a commit, it's important to update |
package.yaml | ||
stack.yaml | ||
tmp | ||
.DS_Store |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be involved in Exercism? Or is it better to educate contributors on where these go in ~/.gitignore
Anything Haskell related I think should be here, but editor and OS are outside the scope of this project.
Your are right, @kotp. Those patterns did not belong here. Thanks! I rewrote it completely with some comments and I would appreciate if you could take another look at that. 😄 |
Yep, looks better. Thanks! If you sort those in each categories, I think that would be an improvement, and will allow any additional changes to be in some easily scanned and findable order. |
Done. Thanks, again! |
All seems reasonable. If we are really wanting to nit I would note that I more commonly see "specific" than "especific" but of course this is minor. |
Based on default .gitignore from github/gitignore/Haskell.gitignore Keep exercism's specific patterns: - bin/configlet - bin/configlet.exe Add xhaskell's specific patterns: - *.cabal - package.yaml - stack.yaml Remove everything else. The xhaskell specific patterns are desirable to avoid accidental inclusions from developers using stack, hpack and cabal-sandboxes, because the exercises and tests do not include project files.
Fixed and now mostly English compliant, @petertseng. 😄 |
only mostly?! =D all seems good to me 👍 |
Add new entries to .gitignore to make move convenient for
contributors to use alternative build methods.