Skip to content

New .gitignore based on GitHub's default. #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2016
Merged

New .gitignore based on GitHub's default. #160

merged 1 commit into from
Jun 23, 2016

Conversation

rbasso
Copy link
Contributor

@rbasso rbasso commented Jun 22, 2016

Add new entries to .gitignore to make move convenient for
contributors to use alternative build methods.

  • Default .ignore exclusions for Haskell from GitHub.
  • Exclusions for development with cabal-sandboxes, stack and hpack.
  • Reordering.

@rbasso
Copy link
Contributor Author

rbasso commented Jun 22, 2016

At the moment, it's only practical to build the examples and tests in xhaskell using a globally installed GHC or a global Stack profile. With #159 , it will be possible to build and test exercises locally as auto-contained projects.

To avoid accidental inclusion of build directories and local project files in a commit, it's important to update .gitignore. Given the opportunity, we also update it with all the most common exclusions for Haskell development.

package.yaml
stack.yaml
tmp
.DS_Store
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be involved in Exercism? Or is it better to educate contributors on where these go in ~/.gitignore Anything Haskell related I think should be here, but editor and OS are outside the scope of this project.

@rbasso rbasso changed the title Add new entries to .gitignore New .gitignore based on GitHub's default. Jun 22, 2016
@rbasso
Copy link
Contributor Author

rbasso commented Jun 22, 2016

Your are right, @kotp. Those patterns did not belong here. Thanks!

I rewrote it completely with some comments and I would appreciate if you could take another look at that. 😄

@kotp
Copy link
Member

kotp commented Jun 22, 2016

Yep, looks better. Thanks!

If you sort those in each categories, I think that would be an improvement, and will allow any additional changes to be in some easily scanned and findable order.

@rbasso
Copy link
Contributor Author

rbasso commented Jun 23, 2016

Done.

Thanks, again!

@petertseng
Copy link
Member

All seems reasonable. If we are really wanting to nit I would note that I more commonly see "specific" than "especific" but of course this is minor.

Based on default .gitignore from github/gitignore/Haskell.gitignore

Keep exercism's specific patterns:
- bin/configlet
- bin/configlet.exe

Add xhaskell's specific patterns:
- *.cabal
- package.yaml
- stack.yaml

Remove everything else.

The xhaskell specific patterns are desirable to avoid accidental
inclusions from developers using stack, hpack and cabal-sandboxes,
because the exercises and tests do not include project files.
@rbasso
Copy link
Contributor Author

rbasso commented Jun 23, 2016

Fixed and now mostly English compliant, @petertseng. 😄

@petertseng
Copy link
Member

only mostly?! =D

all seems good to me 👍

@rbasso rbasso merged commit cc39bb7 into exercism:master Jun 23, 2016
@rbasso rbasso deleted the add-exclusions-to-gitignore branch July 1, 2016 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants