Skip to content

meetup: Rewrite tests to use hspec with fail-fast. #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2016
Merged

meetup: Rewrite tests to use hspec with fail-fast. #235

merged 1 commit into from
Jul 31, 2016

Conversation

rbasso
Copy link
Contributor

@rbasso rbasso commented Jul 26, 2016

Related to #211.

@petertseng
Copy link
Member

I will say 👍 because the tests pass though I admit I didn't take a very close look due to the sheer number of the tests. I do wonder if quickcheck would be a good idea (especially now that octal and trinary our only exercises with quickcheck are getting deprecated), but that's nothing to do with hunit->hspec, a separate issue. I don't have time to do it myself for a while.

@rbasso
Copy link
Contributor Author

rbasso commented Jul 30, 2016

I do wonder if quickcheck would be a good idea (especially now that octal and trinary our only exercises with quickcheck are getting deprecated).

Now that we are using Stack, we have no reason to reduce the number of dependencies. The only thing I don't like about QuickCheck is that random testing doesn't allow tests to be designed so that exercises would be solved iteractively, case after case, with increasing complexity.

@rbasso rbasso merged commit a993258 into exercism:hspec-fail-fast Jul 31, 2016
@rbasso rbasso deleted the hspec-meetup branch July 31, 2016 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants