binary: Rewrite tests to use hspec with fail-fast. #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
on the one hand, the behavior hasn't changed, so I shouldn't compain too much, but on the other hand, the tests now have descriptions that specifcally include the words "raises an error" yet an expectation of zero certainly isn't raising an error, so adding the descriptions makes the existing tests make less sense! Is it time to do something about this? |
|
Well....this came from I'll change the strings just to avoid the confusing error messages! |
- Rewrite tests to use hspec. - Update tests to match the json file. - Fix test descriptions mentioning "errors".
|
Updated the descriptions mentioning errors |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #211.