Skip to content

raindrops: Rewrite tests to use hspec with fail-fast. #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2016
Merged

raindrops: Rewrite tests to use hspec with fail-fast. #244

merged 1 commit into from
Aug 1, 2016

Conversation

rbasso
Copy link
Contributor

@rbasso rbasso commented Aug 1, 2016

  • Rewrite test to use hspec
  • Remove test not matching x-common.

Related to #211.

@petertseng
Copy link
Member

👍 as-is, but while we're thinking about it, how about a potential question:

For all cases, it is true that description is just show number. Given this consideration, is description really necessary? Then again, I imagine these were generated straight from the JSON file, so this question may have been better for the JSON file in x-common.

So 👍 here.

@rbasso
Copy link
Contributor Author

rbasso commented Aug 1, 2016

I agree! It's ugly to have the descriptions equal to the numbers. Considering that they don't add any useful information, It would be nice to remove them in x-common, but I can also remove it now from xhaskell. Should I do it?

Edit: Done. :)

@petertseng
Copy link
Member

Ah, right. 👍 then, no question.

Optional: This would be a candidate to use tuples since the two fields should be unambiguous, as in prime-factors the other PR, but as I've said I do not object to a record even if there is an opportunity to use a tuple.

- Rewrite test to use hspec
- Remove test not matching x-common.
@rbasso
Copy link
Contributor Author

rbasso commented Aug 1, 2016

That was fast, @petertseng!

I'm followed your advice and changed to tuples. 👍

@petertseng
Copy link
Member

👍

@rbasso rbasso merged commit 8898ea1 into exercism:hspec-fail-fast Aug 1, 2016
@rbasso rbasso deleted the hspec-raindrops branch August 1, 2016 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants