Skip to content

largest-series-product: Rewrite tests to use hspec with fail-fast. #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2016
Merged

largest-series-product: Rewrite tests to use hspec with fail-fast. #257

merged 1 commit into from
Aug 6, 2016

Conversation

rbasso
Copy link
Contributor

@rbasso rbasso commented Aug 3, 2016

  • Rewrite tests to use hspec.
  • Update tests to match x-common.
  • Rewrite example solution to pass the tests.

Related to #211.

@rbasso
Copy link
Contributor Author

rbasso commented Aug 3, 2016

It's important to note that, because this PR changes the tests to match the newer and more detailed cases from x-common, this exercise will be a little harder.

- Rewrite tests to use `hspec`.
- Update tests to match `x-common`.
- Rewrite example solution to pass the tests.
@petertseng
Copy link
Member

👍 , though did you think the exercise needed to be moved around because of the increased difficulty? Though I suppose that's a question that can be deferred until #193 is tackled.

@rbasso
Copy link
Contributor Author

rbasso commented Aug 6, 2016

It's not so much more difficult, so we can re-position it later. 😄

@rbasso rbasso merged commit 2f3590d into exercism:hspec-fail-fast Aug 6, 2016
@rbasso rbasso deleted the hspec-largest-series-product branch August 6, 2016 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants