-
-
Notifications
You must be signed in to change notification settings - Fork 195
Merge unfinished hspec-fail-fast to master #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rewrite to use hspec. - Add tests to match the json file. - Remove old test not matching the json file. - Fix solution to work with the new test cases.
- Rewrite to use hspec. - Update to match the json file.
- Rewrite tests to use hspec. - Rewrite example to accept json tests.
- Rewrite to use hspec. - Add tests to match the json file. - Remove most of the tests not matching the json file.
- Rewrite to use hspec. - Replace old tests by tests matching the json file.
- Rewrite to use hspec with fail-fast. - Change tests to make them more polymorphic.
leap: Rewrite tests to use hspec with fail-fast.
accumulate: Rewrite tests to use hspec with fail-fast.
sublist: Rewrite tests to use hspec with fail-fast.
grains: Rewrite tests to use hspec with fail-fast.
gigasecond: Rewrite tests to use hspec with fail-fast.
bob: Rewrite tests to use hspec with fail-fast.
sum-of-multiples: Rewrite tests to use hspec with fail-fast.
strain: Rewrite tests to use hspec with fail-fast.
- Rewrite tests to use `hspec`. - Remove old tests. - Add tests to match `x-common`. - Remove import of `Robot` in test suite. - Remove export of `Robot` in example solution. - Remove export of `Robot` in stub solution. - Remove instructions to derive `(Eq, Ord)` in stub.
robot-simulator: Rewrite tests to use hspec with fail-fast.
crypto-square: Rewrite tests to use hspec with fail-fast.
- Completely rewrite tests to match `x-common/triangle.json`. - Fix example solution to pass the new test suite. - Fix the stub solution to match changes in `TriangleType`.
- Rewrite tests to use `hspec` - Remove use of `unlines`
triangle: Rewrite to match the new json file.
bank-account: Rewrite tests to use hspec with fail-fast.
house: Rewrite tests to use hspec with fail-fast.
clock: Rewrite tests to use hspec with fail-fast.
- Rewrite test to use hspec. - Add failed equality test.
matrix: Rewrite tests to use hspec with fail-fast.
- Rewrite tests to use `hspec`. - Remove use of `unlines`.
minesweeper: Rewrite tests to use hspec with fail-fast.
ocr-numbers: Rewrite tests to use hspec with fail-fast.
food-chain: Rewrite tests to use hspec with fail-fast.
wordy: Rewrite tests to use hspec with fail-fast.
trinary: Rewrite tests to use hspec with fail-fast.
octal: Rewrite tests to use hspec with fail-fast.
linked-list: Rewrite tests to use hspec with fail-fast.
I think I already reviewed all these in their individual form, so I am confident in 👍 here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ongoing migration to
hspec
will continue to be tracked by #211, with PRs based onmaster
.Closes #263.
Closes #278.