palindrome-products: Rewrite tests to use hspec with fail-fast. #286
Conversation
|
Seems good. Don't let this hold up merging, but a question! Regarding the experiment to use HINTS.md: What result do you think you will use to decide whether to apply it to other exercises? |
| cases = [ ("palindromes from single digit factors", 1, 9, 1, [( 1, 1)], 9, [(1, 9), (3, 3)]) | ||
| , ("palindromes from double digit factors", 10, 99, 121, [( 11, 11)], 9009, [( 91, 99)]) | ||
| , ("palindromes from triple digit factors", 100, 999, 10201, [( 101, 101)], 906609, [( 913, 993)]) | ||
| , ("palindrome from four digit factors" , 1000, 9999, 1002001, [( 1001, 1001)], 99000099, [( 9901, 9999)]) |
There was a problem hiding this comment.
simgular versus plural, maybe they should all be the same?
There was a problem hiding this comment.
Nice catch! Fixed! 😄
- Rewrite tests to use `hspec`. - Add `HINTS.md`. - Move old hints to `HINTS.md`. - Update the stub solution.
Right now we have hints as comments in the test suites and in the stub solutions. The comments in the stub solutions proved to be a tragedy, because most of the users just leave the hints in the submitted code. The comments in the test suite are not that bad, but I think that the users should get feedback primarily running the test suite, not inspecting it. If the hints file works as expected, I think it would be probably a good idea to do the same for all exercises. But first I would like to check if it is correctly inserted in the What do you think about it? |
|
I wish I could just search for https://github.com/search/advanced?l=&q=org%3Aexercism++path%3AHINTS.md&ref=advsearch&type=Code&utf8=%E2%9C%93 but I was not able to get this to work. Maybe someone else will have better luck. Oh well, at least I know that xrust has https://github.com/exercism/xrust/blob/master/exercises/space-age/HINTS.md |
|
Also I do know about xelixir, which does something similar: https://github.com/exercism/xelixir/tree/master/exercises/zipper/hints There it is a subfolder in the exercise, containing a |
hspec.HINTS.md.HINTS.md.We took the opportunity to use this PR as a first experiment with
HINTS.mdin the Haskell track.Related to #211.