Skip to content

series: Rewrite tests to use hspec with fail-fast. #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2016
Merged

series: Rewrite tests to use hspec with fail-fast. #294

merged 1 commit into from
Sep 13, 2016

Conversation

rbasso
Copy link
Contributor

@rbasso rbasso commented Sep 12, 2016

Related to #211.

@petertseng
Copy link
Member

👍

@rbasso rbasso merged commit 921a937 into exercism:master Sep 13, 2016
@rbasso rbasso deleted the hspec-series branch September 13, 2016 06:32
@petertseng
Copy link
Member

Do you think it would be instructive and/or useful to test that series 0 "" shouldBe [[]] and series 0 "hi" shouldBe [[]]? I felt strongly about testing size 0 in largest-series-product, but do not feel so strongly here.

@rbasso
Copy link
Contributor Author

rbasso commented Sep 13, 2016

Your proposed tests seem correct to me.

Some submissions based on Data.List.Split.divvy would certainly break. Because it is implemented in what I humbly call "the wrong way", but there is always a price for changes, and that's ok.

It's you call! If you write the PR, I'll certainly merge it. 😄

@petertseng
Copy link
Member

It's now ocurred to me to ask - what would the divvy solutions say that series 0 "" is?

@rbasso
Copy link
Contributor Author

rbasso commented Sep 15, 2016 

Prelude Data.List.Split> divvy 0 1 ""
[]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbasso @petertseng