house: Fix tests to match x-common and add working stub solution. #348
Conversation
|
Oh, no line by line comparison this time? Is this OK? You know what would be really awesome? If hspec has a specialised |
| - Try to reduce repetition to a minimum. | ||
| - Try to make the code readable. | ||
|
|
||
| Take your time. |
There was a problem hiding this comment.
https://www.youtube.com/watch?v=RuqaVryDRd0&t=10
Ignore this comment of mine, it is not serious.
I was not sure if I should use the same structure as Well, I guess that is better than nothing. 😄 Fixing it now!
I completely agree with you! That would be perfect! I'll try to remember to take a look at that later, to see if we can write something like this. |
- Use lyrics from `x-common/exercises/house/description.md`. - Tests all lines, one by one, and then the entire song. - Add stub solution passing the tests. - Patch example solution to work with the new tests.
|
Tests updated to use @petertseng's code to compare the lyrics, taken from |
|
I haven't tested it yet, but I guess there is a
https://github.com/myfreeweb/hspec-expectations-pretty-diff#readme It is already available in the current snapshot: https://www.stackage.org/nightly-2016-07-17/package/hspec-expectations-pretty-diff-0.7.2.4 |
HINTS.mdexplaining that this exercise is about refactoring.description.mdinx-common.Related to #301.