hspec-lens-person: Rewrite test to use hspec with fail-fast. #381
Conversation
|
|
||
| bornStreet :: Born -> String | ||
| bornStreet = undefined | ||
|
|
||
| setCurrentStreet :: String -> Person -> Person | ||
| setCurrentStreet = undefined | ||
| renameStreets :: (String -> String) -> Person -> Person |
There was a problem hiding this comment.
Oh, I see. You made the stub file follow alphabetical order.
The old argument for having them in this order is that a plain set is probably easier than a transform (sorry that I forget the lens specific terminology), and if students implement from top to bottom, they should probably implement the easier ones first.
However, at this point the tests should be guiding the implementation order since the tests will be run in order and the first one will fail.
I'm okay with this, let me know if I missed anything in my reasoning and/or there are other concerns
There was a problem hiding this comment.
I'm not sure if top level functions should be defined in a solution specific order or if they should be alphabetical.
Alphabetical order usually makes finding things easier, and I usually do the same in the exports list, to match. But I don't have a very strong opinion on this.
I left the data declarations in topological order. I'm inconsistent. 😁
Should I revert the functions to their old ordering?
There was a problem hiding this comment.
Fixed. Just reverted to the old order. 👍
|
|
||
| -- Valid values of Gregorian are those for which 'Data.Time.Calendar.fromGregorianValid' | ||
| -- returns Just. | ||
| data Gregorian = Gregorian { |
There was a problem hiding this comment.
yeah I never understood this; I just deleted it in my submission
- Rewrite tests to use `hspec`. - Remove unneeded data type `Gregorian` and rewrite stub.
hspec.Gregorianand rewrite stub.Related to #211 and #302.