Skip to content

new exercise bowling #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2016
Merged

new exercise bowling #439

merged 2 commits into from
Nov 21, 2016

Conversation

abo64
Copy link
Contributor

@abo64 abo64 commented Nov 21, 2016

No description provided.

Copy link
Contributor

@rbasso rbasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing one more exercise, @abo64!

Except for the comment in the stub solution, everything seems great. 👍

module Bowling (bowlingStart, roll, score) where

-- modify this appropriately
data Bowling = Bowling
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since #302 , the stub solutions do not have comments anymore.

We did this because most people where submitting solutions without removing them, and HINTS.md seemed the most appropriate place, so people will have to get used to reading the README.md file in case of trouble.

Also, to mark data types that need to be changed by the user, we are using Dummy and adding instructions in HINTS.md. Take a look at the exercises forth, custom-set and binary-search-tree that we fixed; all of them now have a HINTS.md and a data type to be implemented.

We are trying to make the stub solutions allow compiling and running the tests when that doesn't ruin the exercise, so it would be nice if this exercise could allow that from the start #421.

@abo64
Copy link
Contributor Author

abo64 commented Nov 21, 2016

I appreciate your continuous efforts to improve the exercises!
It makes it somewhat harder for contributors, but the end result is worth it.

I considered to change bowlingStart to empty but decided to keep the more telling name. Hope that's ok with you.

btw perhaps you can do the squashing this time to avoid the mess I created last time? :-)

@rbasso
Copy link
Contributor

rbasso commented Nov 21, 2016

It makes it somewhat harder for contributors, but the end result is worth it.

Sorry for that! We should definitely write instructions on how to implement an exercise to make things easier for contributors.

The fact is that until now we didn't standardized a format for the exercises, because we are still evolving the infrastructure and some of the exercises do not fit in anything.

An alternative would be to avoid standardization, but with more than 70 exercises it is really hard to keep things updated and manageable.

@rbasso rbasso merged commit 2f16551 into exercism:master Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants