Skip to content

pov: Add dummy symbolic link #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2016
Merged

pov: Add dummy symbolic link #454

merged 2 commits into from
Dec 5, 2016

Conversation

rbasso
Copy link
Contributor

@rbasso rbasso commented Dec 4, 2016

In #442 we conjectured that using symbolic links to a common stack.yaml would be feasible, but the test (#443) didn't work as expected.

The result of the experiment was a pov exercise without a stack.yaml file, and #453 was opened on fix that.

To keep testing symbolic links, we still need to use pov as a test bed, but this time without breaking it, so we use another symbolic link name, unrelated to the exercise.

@petertseng
Copy link
Member

I considered using a file whose name starts with ., but I don't really care that much either way. Maybe it will keep a student from asking about it, but who knows whether they would actually miss it

To test if fetching a symbolic link works as expected, we need
an exercise to use as a test bed. This is the last exercise in
the track, so it seems the best candidate to hold this dummy
symbolic link to `common/stack.yaml`.
@rbasso
Copy link
Contributor Author

rbasso commented Dec 5, 2016

I considered using a file whose name starts with .

Makes perfect sense, @petertseng! Fixed!

@rbasso rbasso merged commit 860ee70 into exercism:master Dec 5, 2016
@rbasso rbasso deleted the pov-add-dummy-symbolic-link branch December 5, 2016 06:17
petertseng added a commit that referenced this pull request Mar 31, 2017
Revert "pov: Add dummy symbolic link (#454)" and "common: Add folder with common exercise's files"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants