Skip to content

stubs: add explicit argument to allergies function #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mttakai
Copy link
Contributor

@mttakai mttakai commented Feb 14, 2017

Anagram: add explicit arguments to stub function

Related to issue #473.
see also #496 #491

Copy link
Contributor

@rbasso rbasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR!

@@ -14,4 +14,4 @@ allergies :: Int -> [Allergen]
allergies = error "You need to implement this function."

isAllergicTo :: Allergen -> Int -> Bool
isAllergicTo = error "You need to implement this function."
isAllergicTo allergen n = error "You need to implement this function."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great!

@@ -14,4 +14,4 @@ allergies :: Int -> [Allergen]
allergies = error "You need to implement this function."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function also needs an explicit argument. You can call it n to keep consistency.

@rbasso
Copy link
Contributor

rbasso commented Mar 1, 2017

Considering that this PR had no activity in the last two weeks, I'll close it for now.

Of course, we can reopen it later if @mttakai decides to continue with it.

@rbasso rbasso closed this Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants