-
-
Notifications
You must be signed in to change notification settings - Fork 195
all-exercises: Add/move versioning to package.yaml #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Intentionally, we are leaving a comment in the test suite referring to the origin of the lyrics, because this exercise doesn't try to follow 'x-common', but it extracted the lyrics from there.
Intentionally, we are leaving a comment in the test suite referring to the origin of the lyrics, because this exercise doesn't try to follow 'x-common', but it extracted the lyrics from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great.
81 * 2 is 162 - the five test files that did not change are
- hello-world, zebra-puzzle (did not have comments to begin with)
- beer-song, food, chain, house (reason for leaving comment is explained)
So all files are accounted for
It will be useful to do that so we can declare ourselves up to date if we are in fact up to date. Any plans to do it? If I do not hear that someone else is doing it sometime, I may start doing it, but it would be a shame if I duplicated work. I ask because I just did the same for another track in exercism/rust#282 |
It would be great if you could do that, @petertseng! 😄 |
Move the exercise's versioning information from the test suites to the
package.yaml
files, including sensible default versions when no information is available.Checking if the contents of the test suite matches the
canonical-data.json
file is not in the scope of this PR.Related to #522.