-
-
Notifications
You must be signed in to change notification settings - Fork 195
all: Remove test group with the exercise's name #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: Remove test group with the exercise's name #540
Conversation
Before I review this! See how the test version was not updated as they were in #539! I don't actually care whether they get updated, but it is your opportunity to update them before I get too far in review. Several hours before I review. |
I guess it is fixed now, @petertseng! I updated the versions of all exercises - except for Everything was edited by hand, but the commits where generated using a loop, so they should have identical messages, except for the exercise's name. To help in the review, here are the totals:
|
I am sorry to say... you said "Remote" in all the commit messages (probably meant "Remove") |
Hahahaha! Don't be sorry! Nice catch, @petertseng! Fixed! |
The exercise's name is already displayed when running the test suite, so there is no need to have a test group just to display it.
This PR remove those labels that I, unfortunately, added to all exercises when porting the exercises to use
hspec
.