Skip to content

all: Remove test group with the exercise's name #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 79 commits into from
May 10, 2017
Merged

all: Remove test group with the exercise's name #540

merged 79 commits into from
May 10, 2017

Conversation

rbasso
Copy link
Contributor

@rbasso rbasso commented May 9, 2017

The exercise's name is already displayed when running the test suite, so there is no need to have a test group just to display it.

This PR remove those labels that I, unfortunately, added to all exercises when porting the exercises to use hspec.

@petertseng
Copy link
Member

Before I review this! See how the test version was not updated as they were in #539!

I don't actually care whether they get updated, but it is your opportunity to update them before I get too far in review. Several hours before I review.

@rbasso
Copy link
Contributor Author

rbasso commented May 10, 2017

I guess it is fixed now, @petertseng!

I updated the versions of all exercises - except for change and luhn - that where not changed here. The version changes where added to each individual commit.

Everything was edited by hand, but the commits where generated using a loop, so they should have identical messages, except for the exercise's name.

To help in the review, here are the totals:

  • We have 81 exercises. 79 where changed in this PR. change and luhn where changed previously.
  • There should be two files changed in each commit: package.yaml and test/Tests.hs. They where added to the commits in a loop, so I expect not to have committed changes to other files.
  • In some exercises I had to remove the import of describe to avoid problems with -Wall.

@petertseng
Copy link
Member

I am sorry to say... you said "Remote" in all the commit messages (probably meant "Remove")

rbasso added 26 commits May 10, 2017 14:49
rbasso added 26 commits May 10, 2017 14:49
@rbasso
Copy link
Contributor Author

rbasso commented May 10, 2017

Hahahaha! Don't be sorry!

Nice catch, @petertseng!

Fixed!

@rbasso rbasso merged commit 1a69cc3 into exercism:master May 10, 2017
@rbasso rbasso deleted the remove-exercise-name-test-group branch May 10, 2017 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants