-
-
Notifications
You must be signed in to change notification settings - Fork 195
matrix: Remove string tests #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I drew a different conclusion from #541 - I thought that the parsing (in particular, parsing a matrix of ints) was okay, it was simply the tests of parsing a matrix of strings (the two that say "may be tricky") that should have been removed. The matrix of chars probably could go too. The https://github.com/exercism/x-common/blob/master/exercises/matrix/description.md does mention "given a string with embedded newlines", which does imply that the string parsing was an intended part... just probably not matrices containing non-numbers. It is true that I wouldn't mind removing the parsing completely (there is already a lot in this exercise) and leaving it for another exercise - please indicate if that is an intended route. |
Oh! When I was reading the exercise I thought that having Right now I'm a little busy, but I can rewrite the PR in a in a day or two. If anyone want to fix it before that, fell free to open another PR and close this one. |
PR Updated to just remove the three final tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you commented saying remove the final three, but removed only the final two. however, the commit contents are consistent with the commit message (removing tricky string). intentional?
Nice catch, @petertseng. Thanks for checking that! I guess I forgot to push after deciding to remove the third one.
I considered that the third one was also in the trick, so I'm keeping the description. Ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed (now only matrices of numbers)
We forgot to increment the test version (the fourth component) |
It was argued in #541 that the the exercise would be more interesting without thefromString
function, which is not an essential part of of it.Rewrite test suite to use[[Int]]
instead ofString
.Remove test that wouldn't make sense withoutfromString
.Remove all other references tofromString
.FixHINTS.md
to remove reference to invalid characters.Edit:
The scope of this PR was restricted to just removing the last three tests, based on the discussion below. If in the future we decided to completely remove
fromString
from the test suite,description.md
will demand some rewriting.I think that it is preferable to completely rewrite or remove this exercise. The way it is now is lacks focus and also exposes users to a really unidiomatic interface.
Closes #541.