Implement exercise protein-translation #585

clementi · 2017-08-02T15:30:05Z

No description provided.

levex · 2017-08-02T19:47:16Z

Why is this commit empty?

clementi · 2017-08-02T19:57:43Z

The section "Avoiding Duplicate Work" in the document "Porting an Exercise to Another Language Track" indicates that one should create an empty WIP PR to indicate that you're working on the particular exercise. Maybe I've done this incorrectly?

levex · 2017-08-02T19:59:41Z

Apologies, I wasn't aware of that!

Fix typo Fix typo Implement exercise Genericize package.yaml Add protein-translation to config.json Simplify expression Provide for invalid codon

clementi · 2017-08-21T22:03:55Z

This exercise has now been implemented and the PR is ready for review.

clementi · 2017-08-26T18:14:31Z

@kytrinyx or @levex or whoever, this is ready for review.

Sent from my Motorola XT1575 using FastHub

kytrinyx · 2017-09-01T14:09:34Z

Thank you @clementi! I've pinged the Haskell track maintainers so that they can take a look at it.

@levex If you have a few moments to spare to provide your input that would be valuable as well. ✨

kytrinyx · 2017-09-01T14:11:08Z

config.json

@@ -780,7 +789,7 @@
      "uuid": "d5997b60-e54c-4caa-beae-8614f0da3fb3",
      "slug": "trinary",
      "deprecated": true
-    }
+    }    


Would you run configlet fmt . using the latest release of our Configlet tool? It helps us ensure that tracks are configured properly and normalized.

kytrinyx · 2017-09-01T14:13:18Z

config.json

+      "core": false,
+      "unlocked_by": null,
+      "difficulty": 1,
+      "topics": [


Do you have any suggestions about what topics this exercise might touch upon?

We have a list of some common topics in https://github.com/exercism/problem-specifications/blob/master/TOPICS.txt - but you are not restricted to the topics in that list. If there are any new Haskell-specific topics or language-features that this exercises uses, those would be a good choice.

levex · 2017-09-01T14:54:39Z

exercises/protein-translation/examples/success-standard/src/ProteinTranslation.hs

+toProtein :: String -> [String]
+toProtein strand = takeWhile ("STOP" /=) $ map codonToProtein $ chunksOf 3 strand
+
+codonToProtein :: String -> String


Just a quick question, maybe I'm missing something, but to me the description is a little misleading. It seems that the correct solution would be just to do the map operation written in the description, but judging by this and the test cases it seems that it actually expects the protein names instead of the codons?

I was basing this off the Scala version: http://exercism.io/exercises/scala/protein-translation/test-suite

petertseng

Thanks.

petertseng · 2017-09-15T01:30:15Z

config.json

@@ -782,7 +791,7 @@
      "uuid": "d5997b60-e54c-4caa-beae-8614f0da3fb3",
      "slug": "trinary",
      "deprecated": true
-    }
+    }    


please remove these spaces, as they have nothing to do with adding the exercise

petertseng · 2017-09-15T01:32:12Z

config.json

+      "slug": "protein-translation",
+      "core": false,
+      "unlocked_by": null,
+      "difficulty": 1,


I was going to ask about difficulty 1 because I didn't think this exercise is difficulty 1, but given that run-length-encoding is also difficulty 1, I guess I can't complain.

petertseng · 2017-09-15T01:33:54Z

exercises/protein-translation/README.md

@@ -0,0 +1,79 @@
+# Rna Transcription


this is the description for the RNA transcription exercise (https://github.com/exercism/problem-specifications/blob/master/exercises/rna-transcription/description.md), whereas given that this is in the protein-translation directory it needs to be the description of the protein translation exercise: https://github.com/exercism/problem-specifications/blob/master/exercises/protein-translation/description.md

petertseng · 2017-09-15T01:35:26Z

exercises/protein-translation/package.yaml

@@ -0,0 +1,20 @@
+name: protein-translation
+version: 1.0.0.0


given that https://github.com/exercism/problem-specifications/tree/master/exercises/protein-translation/canonical-data.json does not exist (that link will lead to a 404), the version number that is in accordance with the versioning policy (#522) will be 0.1.0.1 rather than 1.0.0.0

petertseng · 2017-09-15T01:35:58Z

exercises/protein-translation/test/Tests.hs

+               , strand      = "UUG"
+               , expected    = ["Leucine"]
+               }
+        , Case { description = "identifies leucine codon (UUG)"


is this case any different from the one immediately above? I see two "identifies leucine codon (UUG)"

petertseng · 2017-09-15T01:37:54Z

exercises/protein-translation/test/Tests.hs

+               , strand      = "AUGUUUUAA"
+               , expected    = ["Methionine", "Phenylalanine"]
+               }
+        , Case { description = "stops translation of longest strand"


I don't understand what "longest" means in this context. Can you clarify? I know that it is the longest strand used in the test cases so far, but I don't understand why that must be specified in the description. To me the important part of this test case is that even if there are codons after STOP, they are not included in the output. Shouldn't that be the description?

petertseng · 2017-10-10T01:18:30Z

I regret that between the dates of August 26 and September 15 (a period of 20 days), it was ready for review, but no maintainer of this track reviewed it.

An >= equivalent period of time (24 days) has passed since my review, and we had unanswered questions about the duplicate description "identifies leucine codon (UUG)" and the meaning of "stops translation of longest strand", which we need answered before being able to merge it. We await your answer, but to get the PR out of the queue for now, we are closing it.

Despite it being closed, we are still open to receiving the answers, and would gladly reopen it upon receiving them. Feel free to reopen it by yourself if the permissions allow that (not familiar enough to know whether it is) or ask us to and we will.

Average-user · 2017-12-04T13:55:10Z

Can I implement this?

petertseng · 2017-12-04T13:57:46Z

Yes. Note that https://github.com/exercism/problem-specifications/blob/master/exercises/protein-translation/canonical-data.json exists now, so take note of it appropriately.

Average-user · 2017-12-04T13:59:23Z

ok, But I'll make a new PR.

petertseng · 2017-12-04T13:59:55Z

Indeed, unfortunately it is not possible to transfer ownership of a PR to someone else, so you will indeed have to make a new one.

Average-user · 2017-12-04T14:00:27Z

Oh, didn't now that

Average-user · 2017-12-04T14:10:53Z

@petertseng Should this be String -> [String] or String -> Maybe [String]?

petertseng · 2017-12-04T14:25:42Z

Ah, because there are strings that could not translate to any sequence of proteins? Okay, I suggest String -> Maybe [String] then. I note the canonical data doesn't have any case that would result in None, so you are not obligated to add any, but would still use Maybe nevertheless.

Thinking about String -> Maybe [Protein] though? Note sure whether I feel like making an ADT for these proteins. Try it out and see what the two options look like, then say why you decided on your choice.

Average-user · 2017-12-04T14:29:19Z

Mmm ADT are fun, I'll see

clementi changed the title ~~[WIP] Implement exercise protein-translation~~ Implement exercise protein-translation Aug 16, 2017

Implement exercise protein-translation

2ee7bdf

Fix typo Fix typo Implement exercise Genericize package.yaml Add protein-translation to config.json Simplify expression Provide for invalid codon

kytrinyx requested a review from a team September 1, 2017 14:08

kytrinyx reviewed Sep 1, 2017

View reviewed changes

Merge branch 'master' into protein-translation

0542029

levex reviewed Sep 1, 2017

View reviewed changes

petertseng reviewed Sep 15, 2017

View reviewed changes

petertseng closed this Oct 10, 2017

petertseng mentioned this pull request Oct 31, 2017

implement-an-exercise-from-specification: Remove avoiding duplicate work section. exercism/legacy-docs#108

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement exercise protein-translation #585

Implement exercise protein-translation #585

clementi commented Aug 2, 2017

levex commented Aug 2, 2017

clementi commented Aug 2, 2017 •

edited

Loading

levex commented Aug 2, 2017

clementi commented Aug 21, 2017

clementi commented Aug 26, 2017 •

edited

Loading

kytrinyx commented Sep 1, 2017

kytrinyx Sep 1, 2017

kytrinyx Sep 1, 2017

levex Sep 1, 2017

clementi Sep 14, 2017

petertseng left a comment

petertseng Sep 15, 2017

petertseng Sep 15, 2017

petertseng Sep 15, 2017

petertseng Sep 15, 2017

petertseng Sep 15, 2017

petertseng Sep 15, 2017

petertseng commented Oct 10, 2017

Average-user commented Dec 4, 2017

petertseng commented Dec 4, 2017

Average-user commented Dec 4, 2017

petertseng commented Dec 4, 2017

Average-user commented Dec 4, 2017

Average-user commented Dec 4, 2017

petertseng commented Dec 4, 2017

Average-user commented Dec 4, 2017

Implement exercise protein-translation #585

Implement exercise protein-translation #585

Conversation

clementi commented Aug 2, 2017

levex commented Aug 2, 2017

clementi commented Aug 2, 2017 • edited Loading

levex commented Aug 2, 2017

clementi commented Aug 21, 2017

clementi commented Aug 26, 2017 • edited Loading

kytrinyx commented Sep 1, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

petertseng left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

petertseng commented Oct 10, 2017

Average-user commented Dec 4, 2017

petertseng commented Dec 4, 2017

Average-user commented Dec 4, 2017

petertseng commented Dec 4, 2017

Average-user commented Dec 4, 2017

Average-user commented Dec 4, 2017

petertseng commented Dec 4, 2017

Average-user commented Dec 4, 2017

clementi commented Aug 2, 2017 •

edited

Loading

clementi commented Aug 26, 2017 •

edited

Loading