go-counting 1.0.0.3: Match new canonical data #665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All implementing tracks have this function, but it is never mentioned. exercism/problem-specifications#1195
I did not consider this to provide any additional value. I asked for this to be removed in exercism/problem-specifications#1195 (comment)
I requested this be added in exercism/problem-specifications#1195 (review) There was an implicit test of this in the 5x5 board, but we'll start small. Note that this track deliberately does not change `territories` to be a map mapping a player to all of their territories, instead keeping it an array of all separate contiguous regions. This is because I (as the track maintainer) believe that keeping it an array provides better fidelity of the board and helps ensure that implementations are doing the right thing.
This seemed a significant distinction, so I requested it in exercism/problem-specifications#1195 (comment)
exercism/problem-specifications#1195 Note that this track deliberately does not change `territories` to be a map mapping a player to all of their territories, instead keeping it an array of all separate contiguous regions. This is because I (as the track maintainer) believe that keeping it an array provides better fidelity of the board and helps ensure that implementations are doing the right thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exercism/problem-specifications#1195