Skip to content

etl: bump the version to 2.0.1 (no changes needed) #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

thalesmg
Copy link
Contributor

It seems that only a version bump is necessary.

Latest changes to this problem:

- exercism/problem-specifications#1536
- exercism/problem-specifications#1575
Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two PRs described show 1.0.1 -> 2.0.0, and then 2.0.0 -> 2.0.1, but our version is 1.0.0. Therefore to be able to make sure we've covered everything, let's also get a link to the 1.0.0 -> 1.0.1 change, exercism/problem-specifications#1526.

We should add it to this PR.

I agree that no further change is necessary, though I guess we could change "a single letter" on https://github.com/exercism/haskell/blob/master/exercises/etl/test/Tests.hs#L18 to "single letter" if we really wanted. I don't really care so much though so I'm inclined to just take this as-is, making sure to add the link to exercism/problem-specifications#1526 when doing so.

I give other maintainers about 48 hours to object, making for a total of about 72 from the time the PR was submitted.

@sshine sshine merged commit 49a2479 into exercism:master Oct 14, 2019
@sshine
Copy link
Contributor

sshine commented Oct 14, 2019

  • changed "a single letter" into "single letter"
  • added the 1.0.0 -> 1.0.1 change to the PR
  • added short descriptions for each version bump
  • squash merged

Thanks for the PR, @thalesmg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants