binary-search: update to v1.3.0 #1620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FridaTveit
approved these changes
Dec 10, 2018
There was a problem hiding this comment.
Looks great, thanks @lemoncurry! 🙂 In this case I'm happy with keeping -1 as the return value if the desired value isn't found. I think that's quite common behaviour. I wouldn't expect it to throw an exception as it's not really an error case and I find optionals a bit messy in Java. So I'm happy to keep it like this 🙂
|
Great points, thank you @FridaTveit ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.2.0 -> v.1.3.0:
See discussion in problem-specifications: binary-search: Use error object instead of sentinel -1 #1338
For now I kept the sentinel -1.
Would you prefer to change from the sentinel -1 to an error object?
Reviewer Resources:
Track Policies