crypto-square: Fix invalid tests #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e instead of the actual order.
jmluy
force-pushed
the
crypto-square
branch
from
5ad85a4 to
8fed213
Compare
jtigger
added a commit
that referenced
this pull request
Sep 18, 2015
crypto-square: Fix invalid tests
|
Thanks again, John! Looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing tests were normalizing the strings based on the square size and not the actual sequence of characters from the columns.
You can refer to the source material where "If man was meant to stay on the
ground god would have given us roots" should be "imtgdvs fearwer mayoogo anouuio ntnnlvt wttddes aohghn sseoau" but were grouped by square size on the existing tests. This is a temporary fix until #55 uses the json file.