-
-
Notifications
You must be signed in to change notification settings - Fork 708
two-fer: add to track #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I was thinking since this is meant to be right after hello world, should we add any readme files that the user might need to read? The description of this exercise introduces test driven development - would it be appropriate to remove |
@Smarticles101 you are right that the purpose of adding this exercise was to allow Hello, World to become as simple as possible, thereby testing user environment, etc. Removing Ignores from Hello, World, and introducing them in this exercise instead supports that goal, so I say 👍 |
How does this look @stkent? |
config.json
Outdated
@@ -12,6 +12,11 @@ | |||
] | |||
}, | |||
{ | |||
"slug": "two-fer", | |||
"difficulty": 1, | |||
"topics": [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This topics entry should be formatting like the others (with a blank line between the brackets).
I think this update to the documentation is good for now, though looking at the content of the two exercises it is clear that we should separately split that content between the two exercises. Ref.:
|
I'm happy to take on the separate work I mention after this PR is merged. |
@Smarticles101 just one change to make in the config formatting, then LGTM! |
@stkent ah, so two-fer is a replacement for what hello-world was, and hello-world should just become the traditional hello world. |
Yep, exactly :) |
Ok, this is ready to merge, I'm just going to wait on hitting the button until I have 30 mins right after to update the documentation around this and hello-word :) |
I'll be taking care of this later this afternoon. |
Reviewer Resources:
Track Policies