Skip to content

Updates now that two-fer is part of the track! #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 28, 2017
Merged

Conversation

stkent
Copy link
Contributor

@stkent stkent commented Jun 26, 2017

Overview:

  • Renamed HINT.md -> HINTS.md track wide so that hints are actually included with the README as they are supposed to be!
  • Updated hello-world to be as dumb as possible, which was why two-fer was introduced in the first place.
  • Removed short getting started guide from hello-world - I felt that it was unclear where one should actually start with that exercise (README? TUTORIAL? GETTING_STARTED?) and that maintaining the duplicated-but-different information between the tutorial and the getting started page was unnecessary overhead.
  • Updated the TUTORIAL.md for hello-world for the new simpler exercise; removed all the steps related to TDDing this exercise since there's now only one test!
  • Moved TDD-related discussion to the HINTS file for two-fer, and made it more of a high-level discussion of how to TDD than previously.

It's quite likely that I made some mistakes here and there in this conversion. Please review closely! A good strategy may be to run the journey test locally, which will fetch copies of these exercises as they will appear to users.


Reviewer Resources:

Track Policies

Copy link
Contributor

@FridaTveit FridaTveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question about the contributing link but apart from that it looks great! Very good explanations of everything :)

## Contribute to Exercism

The entire of Exercism is Open Source and is the labor of love for over
The entire of Exercism is Open Source and is a labor of love for over
100 maintainers and many more contributors.

A starting point to jumping in can be found here:

https://github.com/exercism/problem-specifications/blob/master/CONTRIBUTING.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a different link to the one I've used in the general read me: https://github.com/exercism/docs/tree/master/contributing-to-language-tracks. We should probably be consistent and stick to one of them :P Yours looks easier to read since it's one file instead of many. But the porting an exercise link is broken, and that's one of the most useful bits of the documentation in my opinion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question! I asked upstream (exercism/docs#61) and will wait and see what response I get there before committing one way or the other :)

@stkent
Copy link
Contributor Author

stkent commented Jun 27, 2017

@FridaTveit updated, building now!

Copy link
Contributor

@FridaTveit FridaTveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank @stkent! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants