Update config.json #834
Update config.json #834
Conversation
added topics for the queen-attack problem
There was a problem hiding this comment.
This looks great @Akatsuki06! :) I've suggested one more topic but apart from that it's ready to merge! :)
Also just a small suggestion for the future, it can be helpful if the title of the pull request very clearly states what the pull request is for. For example, for this pull request "queen-attack: add topics" or something like that would make it very obvious what it's about. You state it very nicely in the description but I can't see that when looking at the files, and since I'm doing very many reviews at the moment I can easily forget which review I'm doing :P
But that's only a very minor thing and apart from that this PR looks great! :)
config.json
Outdated
| "arrays", | ||
| "matrices", | ||
| "conditionals", | ||
| "mathematics" |
There was a problem hiding this comment.
These look like great suggestions! :) I would also add games as a topic since this is to do with chess :) Do you agree?
There was a problem hiding this comment.
@FridaTveit
games and also how about tuples ? Can we add even though its not java datatype? or I should specify as classes as this specific program contains custom class BoardCoordinate .
There was a problem hiding this comment.
I wouldn't add tuples since it's not a java datatype so it could be confusing. But classes is a very good suggestion! :)
There was a problem hiding this comment.
I have done the updates
There was a problem hiding this comment.
This looks great @Akatsuki06! :) Will merge it as soon as the build finishes :)
Thanks for taking the time to do the changes! We really appreciate the help :)
added topics for the queen-attack problem
fixes #829
Reviewer Resources:
Track Policies