Renamed classes and added @Before method to test class

[delbertlegg]

Fixes #376

---

Reviewer Resources:

Track Policies

[FridaTveit]

This looks great @delbertlegg! :)

I've left a couple of comments, but they're both relatively minor things.

Thanks for taking the time to do this! :)

[FridaTveit]

Just as a heads up, this will probably be changed as part of issue #230 so that not all the binary search trees used in the tests will be of type Integer. In which case we won't be able to save it as a private variable anymore :( So it's fine to leave it as a private variable for now, the way the tests are structured at the moment it's a really good change :) But just be aware that it might be changed back in the near future :)

Also also, if you do decide to keep it then it should be made private :)

[FridaTveit]

I would probably rename this as well to binarySearchTree because I find that clearer. That's just my preference though, feel free to leave it as it is if you prefer it that way :)

[delbertlegg]

@FridaTveit I can make those changes, no problem. It looks like part of #376 was changed when #230 was made? It sounded like the intent was to instantiate the BinarySearchTree once for the tests, but now it looks like we can't since it may change types for each test?

[FridaTveit]

True, I didn't see that part of #376, sorry! I think it's fine to do what you've done and instantiate it in a @Before block, that's the best thing to do at the moment. But it will probably be changed once #230 is done. So I just wanted to let you know in case you saw that change and were annoyed that your changes were being undone :) Does that make sense? Sorry if I've caused any confusion!

[delbertlegg]

@FridaTveit Makes sense, and no worries! I just want to make sure I understand the problem. I'll change the variable name and make it private for now. And I won't be annoyed about any changes, here to help :).

[FridaTveit]

This looks great, a really good improvement! :) Thanks for taking the time to do this @delbertlegg! :)