Skip to content

Add new exercise simple linked list#99

Merged
kytrinyx merged 1 commit intomasterfrom
new-exercise-simple-linked-list
Mar 6, 2016
Merged

Add new exercise simple linked list#99
kytrinyx merged 1 commit intomasterfrom
new-exercise-simple-linked-list

Conversation

@matthewmorgan
Copy link
Copy Markdown
Contributor

@matthewmorgan matthewmorgan commented Mar 1, 2016

As described in #98

@sit
Copy link
Copy Markdown
Contributor

sit commented Mar 1, 2016

Why both this one and #85?

sit
sit reviewed Mar 1, 2016
View reviewed changes
Comment thread exercises/simple-linked-list/src/example/java/SimpleLinkedList.java Outdated

/**
*
* @author matt
Copy link
Copy Markdown
Contributor

@sit sit Mar 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can teach your IDE not to generate these comments. They probably aren't relevant for this repo.

Copy link
Copy Markdown
Contributor Author

@matthewmorgan matthewmorgan Mar 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point.

@matthewmorgan
Copy link
Copy Markdown
Contributor Author

matthewmorgan commented Mar 1, 2016

@sit "linked-list" is supposed to be doubly linked. This exercise is singly linked. Both are specified in x-common.

Edit: @sit interestingly, the x-common README for 'linked-list' says it should be doubly linked, but the .yml says it should be singly linked! Maybe that needs to be addressed next.

@matthewmorgan matthewmorgan force-pushed the new-exercise-simple-linked-list branch 3 times, most recently from 7a2575f to ada43f8 Compare March 2, 2016 12:01
@matthewmorgan
Copy link
Copy Markdown
Contributor Author

matthewmorgan commented Mar 2, 2016

Refactored to allow generics. Feedback appreciated!

sit
sit reviewed Mar 3, 2016
View reviewed changes
Comment thread exercises/simple-linked-list/src/example/java/SimpleLinkedList.java Outdated
return (T[]) result;
}

private <T> T[] getArray(Class<T> clazz, int size) {
Copy link
Copy Markdown
Contributor

@sit sit Mar 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newArray?

Copy link
Copy Markdown
Contributor Author

@matthewmorgan matthewmorgan Mar 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you suggesting changing the method name?

Copy link
Copy Markdown
Contributor

@sit sit Mar 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, to indicate that it's constructing something (as opposed to getting something).

@matthewmorgan matthewmorgan force-pushed the new-exercise-simple-linked-list branch from ada43f8 to c4b10d7 Compare March 3, 2016 15:42
@matthewmorgan
Copy link
Copy Markdown
Contributor Author

matthewmorgan commented Mar 5, 2016

@sit @jtigger is this OK to merge? Any remaining concerns? Thanks

@sit
Copy link
Copy Markdown
Contributor

sit commented Mar 6, 2016

LGTM.

kytrinyx added a commit that referenced this pull request Mar 6, 2016
@kytrinyx
Merge pull request #99 from exercism/new-exercise-simple-linked-list
b03f4f1 
Add new exercise simple linked list
@kytrinyx kytrinyx merged commit b03f4f1 into master Mar 6, 2016
@kytrinyx
Copy link
Copy Markdown
Member

kytrinyx commented Mar 6, 2016

Thanks!

@matthewmorgan matthewmorgan deleted the new-exercise-simple-linked-list branch March 6, 2016 20:44
@amrtanair amrtanair mentioned this pull request Mar 7, 2016
Closed
@jtigger
Copy link
Copy Markdown
Contributor

jtigger commented Mar 8, 2016

btw, @sit, we were singing your praises, this morning. Great spot
feedback/questions! Thank you, sir! Hoping to help carry forward that
which you started.

On Sun, Mar 6, 2016 at 11:53 AM, Katrina Owen notifications@github.com
wrote:

Thanks!

—
Reply to this email directly or view it on GitHub
#99 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matthewmorgan @sit @kytrinyx @jtigger