Add new exercise simple linked list #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why both this one and #85? |
|
|
||
| /** | ||
| * | ||
| * @author matt |
There was a problem hiding this comment.
You can teach your IDE not to generate these comments. They probably aren't relevant for this repo.
matthewmorgan
force-pushed
the
new-exercise-simple-linked-list
branch
3 times, most recently
from
7a2575f to
ada43f8
Compare
|
Refactored to allow generics. Feedback appreciated! |
| return (T[]) result; | ||
| } | ||
|
|
||
| private <T> T[] getArray(Class<T> clazz, int size) { |
There was a problem hiding this comment.
Are you suggesting changing the method name?
There was a problem hiding this comment.
Yeah, to indicate that it's constructing something (as opposed to getting something).
matthewmorgan
force-pushed
the
new-exercise-simple-linked-list
branch
from
ada43f8 to
c4b10d7
Compare
|
LGTM. |
kytrinyx
added a commit
that referenced
this pull request
Mar 6, 2016
Add new exercise simple linked list
|
Thanks! |
Closed
|
btw, @sit, we were singing your praises, this morning. Great spot On Sun, Mar 6, 2016 at 11:53 AM, Katrina Owen [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #98