-
-
Notifications
You must be signed in to change notification settings - Fork 633
Ensure ECMAScript track is ready for v2 launch #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Things that can be already checked off:
I've submitted pull requests for the blurb #413, and the about section #414. The first exercise is missing "auto_approve", but has "hello-world" as the name of the first exercise - this may need to be fixed later. |
@jackhughesweb thanks for your work on this. It does raise the question of whether it is time to deprecate this track, and move the ES features in to the JavaScript track. Arguments in favor:
@exercism/ecmascripts would anyone care to comment on this, pro or con? |
I agree with @matthewmorgan. Ecmascript has grown a lot over the last few years almost all developers are writing ecmascript these days. Makes very little sense now to maintain two different tracks. And the release of exercism v2 is a nice opportunity to do the transition 😃 |
@tejasbubane my thoughts exactly. :) How we do this is another question, but it makes little sense to duplicate effort going forward to preserve both of these tracks, and we have a nice opportunity for a clean break here. |
Same here. No reason to keep two tracks, and Nextercism is the perfect
opportunity to unite them.
Should we plan an effort to merge the tracks? Maybe we could add some
improvements as general acceptance criteria.
Joel Wallis Jucá
joelwallis.com
Em ter, 12 de jun de 2018 2:30 PM, Matthew Morgan <[email protected]>
escreveu:
… @tejasbubane <https://github.com/tejasbubane> my thoughts exactly. :)
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#412 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AApIXD3BODlzWAvQO20ME59RRbOmSPijks5t7_qigaJpZM4UjsBp>
.
|
Excellent! I'll take a bit of time to think through the details and chat with @iHiD and @nicolechalmers about how to proceed, and get back to you with some concrete suggestions. Meanwhile, if you have thoughts/ideas about things we should remember to do, jot them down here! |
Copying here my recent email to @kytrinyx about this, looking for others' comments and help:
|
This adds the auto_approve property to the hello-world exercise as part of preparing tracks for the v2 launch. The current code on the server will automatically approve hello-world exercises anyway, but that is a temporary fix and will be removed in the future. See #412
opening a new issue for deprecating the JS track and replacing it with this one. #417 |
Matt,
I could help on it. Should I compare the implementations too? EcmaScript
and JavaScript tracks have different ways to implement the exercises. The
first one uses way more classes while the second one uses functions and
constructors. How will we proceed with it? Is it something relevant?
Joel Wallis Jucá
joelwallis.com
Em sáb, 23 de jun de 2018 1:15 PM, Matthew Morgan <[email protected]>
escreveu:
… After more conversation with @kytrinyx <https://github.com/kytrinyx> and
others, I've prepared a few things for deprecating the current JS track.
For V2, the EcmaScript track will become the "new" JavaScript track.
Users' submissions will be migrated as part of the process.
Katrina's notes on the migration process:
We will take the v1 site down in order to launch v2.
The site will have to be offline for 24-48 hours, because we have a
massive data migration that we need to do.
During that time, we can:
- rename https://github.com/exercism/javascript to
https://github.com/exercism/DEPRECATED.javascript
- set active: false in the config of DEPRECATED.javascript
- rename https://github.com/exercism/ecmascript to
https://github.com/exercism/javascript
- delete the GitHub team exercism/javascript
- rename the GitHub team exercism/ecmascript to exercism/javascript
In the meantime, I've closed all open issues and PRs on the JS track as
wontfix, leaving one issue open stating the track will be deprecated. I
have also updated the README to alert users to the deprecation.
On this track, we need to
[ ] identify any exercises that exist in the current JS track but *not*
in this one
[ ] open issues to port those exercises
@tejasbubane <https://github.com/tejasbubane> @joelwallis
<https://github.com/joelwallis> ( @jackhughesweb
<https://github.com/jackhughesweb> ? ) would any of you care to take on
the audit of missing exercises? That step seems to need to be done first.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#412 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AApIXAVY4s_3_taZnngc0rqhjKhVsETuks5t_mmygaJpZM4UjsBp>
.
|
@joelwallis I'll respond on #417 |
@kytrinyx we are late with this, but it appears everything is ready, with the possible exception of 'about page follows formatting guidelines.' I'm happy to check that if you can point me to the formatting guidelines. As far as the deprecation, all the exercises we mentioned in #417 have been ported from the JS track. I think you said that some of these steps could be done as part of migration, which has obviously already happen, so please advise on how we should proceed. |
Great work. Thank you. I think @kytrinyx and I need an hour to plan, then probably an three hours to code a script, then deploy and check. We need some info on people mid-way through an exercise too and to think about how the CLI copes with that. We have to launch Teams before then so I think we're probably targeting maybe around 1st-3rd Aug to do it. If things go badly then maybe towards the next week, although I'll be flat out with the day-job then so I'd like to get it done by the 3rd. |
Yeah 1st-3rd of August would be great. Let me find those formatting guidelines (and let me stick those in some proper documentation!) |
These are the guidelines for the ABOUT.md file: https://github.com/exercism/docs/blob/master/language-tracks/documentation/for-consumers.md#about |
OK thanks. |
This track along with merger of ecmascript has been running well on v2. Closing. Please reopen if something is missed. |
There are a number of things we're going to want to check before the v2 site goes live. There are notes below that flesh out all the checklist items.
TODO
)core
auto_approve: true
Track landing page
The v2 site has a landing page for each track, which should make people want to join it. If the track page is missing, ping
@kytrinyx
to get it added.Blurb
If the header of the page starts with
TODO
, then submit a pull request to https://github.com/exercism/ecmascript/blob/master/config.json with ablurb
key. Remember to get configlet and runconfiglet fmt .
from the root of the track before submitting.About section
If the "About" section feels a bit dry, then submit a pull request to https://github.com/exercism/ecmascript/blob/master/docs/ABOUT.md with suggested tweaks.
Formatting guidelines
In order to work well with the design of the new site, we're restricting the formatting of the
ABOUT.md
. It can use:Additionally:
<br/>
can be used to split a paragraph into lines without spacing between them, however this is discouraged.Code example
If the code example is too short or too wide or too long or too uninteresting, submit a pull request to https://github.com/exercism/ocaml/blob/master/docs/SNIPPET.txt with a suggested replacement.
Exercise metadata
Where the v1 site has a long, linear list of exercises, the v2 site has organized exercises into a small set of required exercises ("core").
If you update the track config, remember to get configlet and run
configlet fmt .
from the root of the track before submitting.Topic and difficulty
Core exercises unlock optional additional exercises, which can be filtered by topic an difficulty, however that will only work if we add topics and difficulties to the exercises in the track config, which is in https://github.com/exercism/ecmascript/blob/master/config.json
Auto-approval
We've currently made any hello-world exercises auto-approved in the backend of v2. This means that you don't need mentor approval in order to move forward when you've completed that exercise.
Not all tracks have a hello-world, and some tracks might want to auto approve other (or additional) exercises.
Track mentors
There are no bullet points for this one :)
As we move towards the launch of the new version of Exercism we are going to be ramping up on actively recruiting people to help provide feedback. Our goal is to get to 100%: everyone who submits a solution and wants feedback should get feedback. Good feedback.
If you're interested in helping mentor the track, check out http://mentoring.exercism.io/
When all of the boxes are ticked off, please close the issue.
Tracking progress in exercism/meta#104
The text was updated successfully, but these errors were encountered: