-
-
Notifications
You must be signed in to change notification settings - Fork 633
Port reverse-string from javascript track #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gavinhenderson thanks for taking this on!
Looks like the build is failing, and we would like you to update the instructions even though the changes there will presumably be changed again by the migration script.
Exercise update looks fine to me though-- when you get your updates I will pull and check it out locally.
exercises/reverse-string/README.md
Outdated
|
||
## Setup | ||
|
||
Go through the setup instructions for JavaScript to install the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll want to update these references so the point to the EcmaScript track for now. We'll need to handle converting them (finally) to JavaScript in the migration.
exercises/reverse-string/README.md
Outdated
http://exercism.io/languages/javascript/installation | ||
|
||
## Running the test suite | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, these should be updated to match the ES setup/test suite instructions. Same goes for the rest of the instructions here.
config.json
Outdated
@@ -30,6 +30,18 @@ | |||
"logic" | |||
] | |||
}, | |||
{ | |||
"slug": "reverse-string", | |||
"uuid": "553a6be7-eecb-45dc-9cea-05126c525f1b", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you'll need to change the UUID. Travis says they need to be unique across tracks, so the build is failing:
-> The following UUID was found in multiple Exercism tracks. Each exercise UUID must be unique across tracks.
@matthewmorgan Thats the changes made |
@gavinhenderson Thanks! 1 down, 5 to go... |
A port of the JS 'reverse-string' challenge as requested in #417
Things I did to port:
it
totest
setup
,requirements
andmaking the test suite pass
sections into exercise README.md