Skip to content

Port reverse-string from javascript track #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2018
Merged

Port reverse-string from javascript track #418

merged 2 commits into from
Jun 25, 2018

Conversation

gavinhenderson
Copy link
Contributor

@gavinhenderson gavinhenderson commented Jun 24, 2018

A port of the JS 'reverse-string' challenge as requested in #417

Things I did to port:

  • Converted it to test
  • Added exercise to config.json and change its UUID
  • Updated tests and example to match new linter
  • Copy ecmascript setup,requirements and making the test suite pass sections into exercise README.md

Copy link
Contributor

@matthewmorgan matthewmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gavinhenderson thanks for taking this on!

Looks like the build is failing, and we would like you to update the instructions even though the changes there will presumably be changed again by the migration script.

Exercise update looks fine to me though-- when you get your updates I will pull and check it out locally.


## Setup

Go through the setup instructions for JavaScript to install the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to update these references so the point to the EcmaScript track for now. We'll need to handle converting them (finally) to JavaScript in the migration.

http://exercism.io/languages/javascript/installation

## Running the test suite

Copy link
Contributor

@matthewmorgan matthewmorgan Jun 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, these should be updated to match the ES setup/test suite instructions. Same goes for the rest of the instructions here.

config.json Outdated
@@ -30,6 +30,18 @@
"logic"
]
},
{
"slug": "reverse-string",
"uuid": "553a6be7-eecb-45dc-9cea-05126c525f1b",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you'll need to change the UUID. Travis says they need to be unique across tracks, so the build is failing:

-> The following UUID was found in multiple Exercism tracks. Each exercise UUID must be unique across tracks.

@gavinhenderson
Copy link
Contributor Author

@matthewmorgan Thats the changes made

@matthewmorgan
Copy link
Contributor

@gavinhenderson Thanks! 1 down, 5 to go...

@matthewmorgan matthewmorgan merged commit f06803a into exercism:master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants