-
-
Notifications
You must be signed in to change notification settings - Fork 201
two-fer: implementation of two-fer exercise in Kotlin #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0a0c987
two-fer: implementation of two-fer exercise in Kotlin
Mouzourides ea58e38
Fix build.gradle
Mouzourides 4ab4f68
Added .keep file to main
Mouzourides 3f04302
Added test with empty parameter and changed assertEquals import
Mouzourides 30951be
Changed code to return "One for , one for me" if empty string is passed.
Mouzourides fd27547
Added comma (I'm a fool)
Mouzourides File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
fun twofer(name: String = "you"): String { | ||
return "One for $name, one for me." | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
`Two-fer` or `2-fer` is short for two for one. One for you and one for me. | ||
|
||
```text | ||
"One for X, one for me." | ||
``` | ||
|
||
When X is a name or "you". | ||
|
||
If the given name is "Alice", the result should be "One for Alice, one for me." | ||
If no name is given, the result should be "One for you, one for me." | ||
|
||
## Instructions | ||
|
||
Submissions are encouraged to be general, within reason. Having said that, it's | ||
also important not to over-engineer a solution. | ||
|
||
It's important to remember that the goal is to make code as expressive and | ||
readable as we can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
buildscript { | ||
ext.kotlin_version = '1.1.4-3' | ||
repositories { | ||
mavenCentral() | ||
} | ||
dependencies { | ||
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version" | ||
} | ||
} | ||
|
||
apply plugin: 'kotlin' | ||
|
||
repositories { | ||
mavenCentral() | ||
} | ||
|
||
dependencies { | ||
compile "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" | ||
|
||
testCompile 'junit:junit:4.12' | ||
testCompile "org.jetbrains.kotlin:kotlin-test-junit:$kotlin_version" | ||
} | ||
test { | ||
testLogging { | ||
exceptionFormat = 'full' | ||
events = ["passed", "failed", "skipped"] | ||
} | ||
} |
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import org.junit.Ignore | ||
import org.junit.Test | ||
import kotlin.test.assertEquals | ||
|
||
|
||
class TwoferTest { | ||
|
||
@Test | ||
fun noNameGiven() { | ||
assertEquals("One for you, one for me.", twofer()) | ||
} | ||
|
||
@Test | ||
@Ignore | ||
fun aNameGiven() { | ||
assertEquals("One for Alice, one for me.", twofer("Alice")) | ||
} | ||
|
||
@Test | ||
@Ignore | ||
fun anotherNameGiven() { | ||
assertEquals("One for Bob, one for me.", twofer("Bob")) | ||
} | ||
|
||
@Test | ||
@Ignore | ||
fun emptyStringGiven() { | ||
assertEquals("One for , one for me.", twofer("")) | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this test should be moved above
anotherNameGiven
?